Rockbox mail archiveSubject: Re: the UI viewport logic.. someone please help my understanding?
Re: the UI viewport logic.. someone please help my understanding?
From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Wed, 28 Oct 2009 21:24:53 +0100
Jonathan Gordon schrieb:
> which is why I said at the start (might have been in irc) that calling
> the sbs statusbars was a very bad idea....
> fullscreen in svn should do fullscreen minus the *current* bar, that
> bar is being removed though so once that happens fullscreen should be
> the real fullscreen. set_defaults (or better named set_uiarea() )
> should return the ui area set by the setting. When that happens you
> have a problem where set_daults() needs to know what type of screen it
> is being called from so it gets the right one (setting or Vi) unless
> you remove Vi (which is what I have been arguing!)
Why? _set_defaults doesn't, and won't, need to know what screen it's
called from. It returns the UI vp (which is in fact default viewport for
the whole UI excluding skins), or returns _set_fullscreen if no UI
viewport is specified. The caller needs to know that (and it obviously
does), and then decides for _set_defaults() or _set_fullscreen().
Received on 2009-10-28