From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sun, 22 Nov 2009 10:52:38 -0800

2009/11/22 Frank Gevaerts <frank_at_gevaerts.be>:
> On Sun, Nov 22, 2009 at 10:21:01AM -0800, Jonathan Gordon wrote:
>> I've said many times that I dont use the recording stuff at all, and
>> that the tokens have been added pretty blindly... I even opened a
>> flyspray task and mentioned it in the commit when those tokes were
>> added... if people dont test as its happening there isnt much I can
>> do.
>
> So you are planning to commit a patch that you *know* is broken?
>
> Frank

Hang on a sec... the current patch (10709) isnt broken... the commit
for the recording tags was probably broken because I tried to do it in
a way that the same skin tokens would work on any recording target
(split into hwcoedc and swcodec groups of course)... now, I obviously
cant test on targets I dont have, and only 1 of my targets actually
has enough rec settings to be useful, yes I think i was fine in doing
what I did...
(have a look at the recording bits in gui/skin_engine/skin_tokens.c to
see how messy it actually is)
Received on 2009-11-22