Rockbox mail archiveSubject: Re: brain dump/plan re simplifying viewport/theme support in screens
Re: brain dump/plan re simplifying viewport/theme support in screens
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Tue, 24 Nov 2009 00:10:18 -0800
Attached is my very quick first effort of doing this change in svn...
it doesnt work, and doesnt even compile yet.. yet enough has changed
so you get some idea of how it simplifies the API a bit (not much
though, but some...)
It turns out that we probably cant completely hide _Set_fullscreen and
set_default to just viewport.c, although I'd really like to....
The reason why one funciton for both (externally) works is because of this:
1) A screen knows how much room it needs... it has exactly 2 choices,
a) use the theme, or b) use full screen.
2) with a single API call it can say "disable the theme, and setup the
viewport for full screen" which does everything else needed in the
background (i.e disabling the sbs updateing, etc)
3) if a screen calls _set_fullscreen without disabling the sbs then
bad things will happen, doing it in 1 api call eliminates that
anyway.. have a open mind over this... we can argue in the morning :)