Rockbox mail archiveSubject: Re: learman: r24968 - trunk/apps
Re: learman: r24968 - trunk/apps
From: Frank Gevaerts <frank_at_gevaerts.be>
Date: Sun, 28 Feb 2010 16:10:36 +0100
On Sun, Feb 28, 2010 at 02:02:03PM +0100, mailer_at_svn.rockbox.org wrote:
> Make the buffer low-level watermark (and the related anti-skip setting) work again. Update the buffering 'base handle' as new tracks start playing, since this is needed to determine how much playable data is left in the buffer. Should fix the buffering problem reported in the forums (http://forums.rockbox.org/index.php?topic=24014.0), and also makes the usefl line in the buffering thread debug screen useful again.
This fixes a pretty serious problem. I think we should consider releasing an update to 3.5 with this commit backported.
-- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. KernighanReceived on 2010-02-28