Rockbox mail archiveSubject: Re: Hotkey patch
Re: Hotkey patch
From: Jeff Goode <jeffg7_at_gmail.com>
Date: Wed, 24 Mar 2010 13:08:29 -0400
On 3/22/2010 12:01, Jeff Goode wrote:
> A working patch for an assignable hotkey is available at FS#11081.
> It's transparent if the target doesn't have HOTKEY defined in its
> config file. So far its functions are limited but the framework is in
> place and it can be easily expanded.
> It's not 100% ready for commitment, mostly because a couple of strings
> aren't in english.lang yet. But I'd like to polish it up a bit and
> commit it soon. I'd also like more targets to be added. I'd
> appreciate any feedback.
Another hotkey patch is at FS#11081. The code is now completely
transparent unless the HOTKEY define is explicitly stated in the target
config file. And hotkey targets now have a lower binsize increase. The
e200 is about 900 bytes.
So now we have to come to a decision: are assignable keys on the NoDo
list or not? The patch is ready for general use and I'd like to
commit. But given some resistance in memory of bygone times, I'm
holding off. Could we come to some consensus now?
Received on 2010-03-24