Rockbox mail archiveSubject: Re: Hotkey patch
Re: Hotkey patch
From: Jeff Goode <jeffg7_at_gmail.com>
Date: Sun, 28 Mar 2010 22:18:11 -0400
On 3/27/2010 19:49, Paul Louden wrote:
> On 3/27/2010 6:46 PM, Jeff Goode wrote:
>> In a couple of different screens, the button I'm using was already
>> assigned. But in one, the bookmark menu, it acts the same as before,
>> with a delete prompt. It's not assignable, just internally renamed.
>> In the other, the WPS, the button was hardcoded to show the
>> playlist. That's still the default behavior, but it can be assigned
>> to another function if desired. I tried to make it so that nothing
>> changed without the user's deliberate action. If you didn't know
>> hotkeys existed, you should be able to continue blissfully unaware of
>> their existence. Unless you assigned a hotkey by accident. But
>> since you can do that only within a context menu and requires a
>> keypress that isn't currently valid, that doesn't seem very likely.
> Maybe a confirmation prompt when changing it? Some people currently
> use that "unassigned" keypress to trigger the backlight if it fades
> (since it still does that) and might not realize they're assigning the
> key to a role.
A confirmation screen is a good idea. I made that change to a patch
I'll upload shortly. I also made it so that if there's no change to the
setting, the keypress is ignored. So you'll only get a confirmation
screen when you attempt to change the setting to a valid function.
Received on 2010-03-29