Rockbox mail archiveSubject: Re: Blue_Dude: r25494 - trunk/apps
Re: Blue_Dude: r25494 - trunk/apps
From: Magnus Holmgren <magnushol_at_gmail.com>
Date: Tue, 06 Apr 2010 18:33:05 +0200
On 2010-04-05 22:53, mailer_at_svn.rockbox.org wrote:
> New Revision: 25494
> Log Message: Restructure some bookmarking code, preparatory to adding
> version info to bookmarks. Saves some bin size as a bonus. No
> functional changes yet.
Some comments, though I don't know exactly what you plan to change (and
are you aware of FS#9407?):
Hm, are the flags really needed? With the struct, it seems like
F_BMFILES flag is the only one... But if they are kept, longer names
would be nice.
Why not pass struct bookmark_values as an argument? No need to keep it
as a static then, and safe to skip (most of) the flags.
resume_first_index can be removed, it isn't used.
Finally, I prefer to not "hide" function calls in macros. Doesn't seem
motivated here, IMHO.
-- MagnusReceived on 2010-04-06