Rockbox mail archive
Subject: Re: WPS playlist viewer exposes a bug in either plaback/buffering or playlist. I'm stumped!Re: WPS playlist viewer exposes a bug in either plaback/buffering or playlist. I'm stumped!
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sat, 17 Apr 2010 22:02:42 +1000
On 17 April 2010 21:16, Magnus Holmgren <magnushol_at_gmail.com> wrote:
> * It uses quite a bit of stack (about 2700 bytes, on ARM at least). Probably
> not a problem, but checking stack usage could perhaps be an idea.
>
> * Looks like "buf" (in draw_playlist_viewer_list) can overflow. Consider
> what happens if "buf_used" goes larger than "sizeof(buf)"... Suggestion: use
> strlcat instead. Protects against overflow and simplifies the code. Don't
> know if that's what causing the problems though.
>
> --
> Magnus
>
fixed both those suggestions.
Received on 2010-04-17
Date: Sat, 17 Apr 2010 22:02:42 +1000
On 17 April 2010 21:16, Magnus Holmgren <magnushol_at_gmail.com> wrote:
> * It uses quite a bit of stack (about 2700 bytes, on ARM at least). Probably
> not a problem, but checking stack usage could perhaps be an idea.
>
> * Looks like "buf" (in draw_playlist_viewer_list) can overflow. Consider
> what happens if "buf_used" goes larger than "sizeof(buf)"... Suggestion: use
> strlcat instead. Protects against overflow and simplifies the code. Don't
> know if that's what causing the problems though.
>
> --
> Magnus
>
fixed both those suggestions.
Received on 2010-04-17
Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy