From: Torne Wuff <torne-rockboxdev_at_wolfpuppy.org.uk>
Date: Mon, 26 Apr 2010 21:57:07 +0100

On Mon, Apr 26, 2010 at 09:52:24PM +0200, Magnus Holmgren wrote:
> The problem is that some of the options for "Bookmark on Stop" and
> "Maintain a List of Recent Bookmarks?" are mutually exclusive. If you
> select "Yes - Recent only" or "Ask - Recent only" in the "Bookmark on
> Stop" option, then you better not select "No" in the "Maintain a List of
> Recent Bookmarks?" option. If you do, you'll only get the "Bookmark
> Failed!" message when trying to create a bookmark. Not very nice...
>
> I think it makes most sense if "Maintain a List of Recent Bookmarks?"
> takes precedence in that case, so that if "Bookmark on Stop" is set to
> "Yes - Recent only" or "Ask - Recent only", no bookmark is actually
> created.
>
> I'm working on an update to the manual regarding bookmarks, so I'd make
> any code changes as a part of that work.

I've wanted the functionality from FS#6272 committed for a while
(autocreate bookmarks only when the bookmark file already exists), but
am not happy with the UI as it stands (it simply makes the set of
options even more complex). Perhaps if this UI were reworked somewhat,
it would be easier to understand even with added options?

-- 
Torne Wuff
torne_at_wolfpuppy.org.uk

Received on 2010-04-26