Rockbox mail archiveSubject: Re: [RaaA] Move SDL stuff to target tree
Re: [RaaA] Move SDL stuff to target tree
From: Thomas Martitz <thomas.martitz_at_student.HTW-Berlin.de>
Date: Fri, 14 May 2010 17:44:23 +0200
Am 08.05.2010 15:41, schrieb Thomas Martitz:
> So, as part of my gsoc project I would like move
> uisimulator/sdl/*.[ch] to the target tree. Specifically into a
> directory firmware/target/hosted/, as hosted would probably also
> contain files for other hosts, such as android, and also (directly
> under hosted/) files which are not dependant on the host very much,
> such as my pth thread implementation.
> This is a large part of the groundwork for an application framework.
> It would look like this (in firmware/target/hosted):
> sdl/timer-sdl.c (the current uisimulator/sdl/timer.c)
> sdl/pcm-sdl. (the current uisimulator/sdl/sound.c)
> sdl/system-sdl.c (for initialization stuff)
> uisimulator/sdl/uisdl.c would be split up across the above files, for
> instance the initialization parts into system-sdl.c, the button parts
> to button-sdl.c etc.
> Additionally, part of sound.c goes as audio-sdl.c under
> firmware/drivers/audio/. Along with this work some SIMULATOR #ifdefs
> would be resovled as the simulator would behave more like a real
> target. BTW, the simulators would/should still work as before, with
> the exception that they're build using the SDL target.
I uploaded a patch which does exactly the above step to FS#11234. Please
have a look, review and drop comments. I really only did mv
uisimulator/sdl/*.[ch] firmware/target/hosted/sdl/, except for uisdl.c
which has been split up across button-sdl.c and system-sdl.c.
An extra change is that the startup is more target like. The entry point
is in main.c and then the init functions are called by the main thread
(previously the entry point was in uisdl.c, which created an extra
thread which would take over the actual main thread).
Received on 2010-05-14