Rockbox mail archiveSubject: WPS_TOKEN_REPLAY_GAIN (%rg) slightly broken
WPS_TOKEN_REPLAY_GAIN (%rg) slightly broken
From: Edgar Toernig <froese_at_gmx.de>
Date: Tue, 8 Jun 2010 00:03:32 +0200
while playing with my theme I noticed that the
replay gain token (%rg) gives random strings when
the track has no replay gain tags and the mode
is set to REPLAYGAIN_SHUFFLE.
intval becomes 8 and string buf is uninitialized.
I think, moving the "if (global_settings...)" into
the preceding "else" should fix it.
skin_tokens.c around line 1388:
if (type < 0)
val = 6; /* no tag */
val = type + 2;
if (global_settings.replaygain_type == REPLAYGAIN_SHUFFLE)
val += 2;
PS: Wishlist: a mono/stereo wps token
Received on 2010-06-08