|
Rockbox mail archiveSubject: Re: Regarding the new %xd feature in r27717Re: Regarding the new %xd feature in r27717
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Thu, 12 Aug 2010 17:20:03 +1000 On 12 August 2010 17:12, Magnus Holmgren <magnushol_at_gmail.com> wrote: > On 2010-08-12 00:54, Jonathan Gordon wrote: > >> Those tags which scale their value needs some work. That is what the >> TOKEN_VALUE_ONLY value is for. The point for that value is so those >> scaled tags dont do any scaling at all, so battery level (when limit >> == TOKEN_VALUE_ONLY) would always be between 0 and 100. If you do want >> to use scaling there then the optional 3rd param overrides that. (so >> %xd(a, %bl) and %xd(a, %bl, 10) would give slightly different >> behaviours. (NOTE> this isnt being done yet though but is on my todo >> list). > > But with the current implementation, that's not what is happening. With > TOKEN_VALUE_ONLY (which is negative), the battery level intval is 1, 2 or 3 > (and the last only only occurs when batter level is 100). > > The third argument is the offset at the moment. Do you plan to change that? > > -- > Magnus > maybe I'm getting confused with my WIP patch and whats in svn. TOKEN_VALUE_ONLY is negative? I'll have a look when I get home an in hour or two Received on 2010-08-12 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |