From: Nils Wallménius <nils.wallmenius_at_gmail.com>
Date: Tue, 24 Aug 2010 16:59:07 +0200

On Tue, Aug 24, 2010 at 8:19 AM, Marcin Bukat <marcin.bukat_at_gmail.com> wrote:
> Hello rockboxers!
> I would like to get some feedback for FS#11534 as I got no single comment on FS.
> Currently the step when changing gain/vol settings in recscreen is
> always 0.1dB. Many (most?)  codecs can't handle such fine grained gain
> changes.
> For example 1.5dB steps are common among wolfson codecs. This patch
> changes the behavior such that step defined in audiohw_settings[] is
> taken when changing gain/vol in recscreen. In my opinion there is no
> reason to fool users that we support something that hardware can't
> handle.
>
> Another thing is that currently every driver claims 0.1dB steps for
> gain in audiohw_settings[] which should be IMO fixed.
>
> looking forward to hear what do You think
> Marcin Bukat (wodz)
>

I agree, telling the user the truth is a Good Thing (TM).

Nils
Received on 2010-08-24