Rockbox mail archiveSubject: Re: [PATCH] Remove some functions & menu entries if plugins are not enabled
Re: [PATCH] Remove some functions & menu entries if plugins are not enabled
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Mon, 4 Oct 2010 23:18:09 +1100
On 4 October 2010 23:06, Rafaël Carré <rafael.carre_at_gmail.com> wrote:
> On Mon, 4 Oct 2010 12:52:52 +0100
> Dave Hooper <dave_at_beermex.com> wrote:
>> How many targets have no plugins due to technical constraints (like
> I think only android, and that would be more because of variable screen
> size rather than lack of keymaps like on other targets.
>> I realise android builds currently have no plugins
>> but I doubt that will be the case forever (I could imagine demand for
>> things like fft and pictureflow)
> Some plugins would be cool indeed, there is also file properties and
> credits which are implemented a bit like viewers.
> ✍ Rafaël Carré ☺
I think this is a bad idea because targets which just disable all
plugins is really due to the dev being lazy. Sure the games wont work,
but alot/many/some of the plugins will work fine, and some are even
required to fully use rockbox (random folder advance config, credits,
A patch which split the plugins into more manageable groups (which can
be separately #ifdefed out would be a much better approach.
Received on 2010-10-04