Rockbox mail archiveSubject: Re: FS#11689 - User settings in skins, and user translation in skins
Re: FS#11689 - User settings in skins, and user translation in skins
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Tue, 26 Oct 2010 11:15:23 +1100
On 26 October 2010 11:05, Thomas Martitz
> On 26.10.2010 01:33, Jonathan Gordon wrote:
>>>> The plan has changed to be one settings file per theme so themers don't
>>>> have to work together (not that that is a bad thing).
>>> I fail to see how that's different from changing the theme directly. If
>>> that's the plan, then it adds nothing.
>> For the same reason tagcache.navi (among others) isnt modified
>> directly, it would get overwritten on updates.
> So the settings file would be a separate download (How does that work with
> the theme site?)? Or would the user need to create it on his own?
> You said "one settings file per theme" which sounded a lot like it would be
> included in the theme.zip to me.
Users would be responsible for creating/updating that file. the
settings themselves are defined in the skin, if you dont create the
file the default value from the definition is used.
> BTW, you said the other purpose is translating. I cannot imagine that
> working out well if there's one settings file (=one language file) per
> Best regards.
translation could be done either way, My thinking is any plain text in
the skin file gets checked for translation at parse time, current
skins wouldnt need any changes. Now if that comes from
/.rockbox/wps/<theme>/translation.txt or /.rockbox/wps/translation.txt
is up for discussion.
Received on 2010-10-26