Rockbox mail archiveSubject: Re: FS#8806 - MikMod MOD, S3M, IT, XM player
Re: FS#8806 - MikMod MOD, S3M, IT, XM player
From: Robert Menes <viewtiful.icchan_at_gmail.com>
Date: Thu, 4 Nov 2010 09:53:37 -0400
On Thu, Nov 4, 2010 at 9:43 AM, Frank Gevaerts <frank_at_gevaerts.be> wrote:
> Are there fundamental reasons not to commit FS#8806? I know that ideally
> we want all sound formats to play via a codec and not a plugin, but the
> way I understand these tracker formats, the codec buffer size would
> really limit the usefulness of such a thing.
> This patch has been on flyspray for ages. It would be nice to finally
> be able to accept it.
Regarding FS##8806, I've used both the codec and plugin versions of the patch
for about a year on various targets. Both versions of the patch
perform very well on
all targets I've used them on, and play everything I could throw at them.
If anything, give both versions a final test and sync them against the
latest SVN, and
if everything looks good, commit! I personally would like to see the
codec version of the
patch accepted, but I have no qualms about the plugin version, either.
Just my $0.02.
-- Nobody's ever lost in life...they're merely taking the scenic route. ============================== Please avoid sending me Word or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html ============================== -----BEGIN GEEK CODE BLOCK----- Version: 3.1.2 GCS/S/M/MU d- s+: a31 C++(+++) UL++++>$ P++ L+++ E+ W+ N+ o+ K++ w--- O- M !V PS+ PE Y+ PGP(+) t+ 5++ X++ R tv b+++ DI+++ D++(---) G++ e+ h- r++ y+ ------END GEEK CODE BLOCK------Received on 2010-11-04