Rockbox mail archiveSubject: Re: FS#8806 - MikMod MOD, S3M, IT, XM player
Re: FS#8806 - MikMod MOD, S3M, IT, XM player
From: Bertrik Sikken <bertrik_at_sikken.nl>
Date: Thu, 4 Nov 2010 17:56:29 +0100
> Are there fundamental reasons not to commit FS#8806? I know that ideally
> we want all sound formats to play via a codec and not a plugin, but the
> way I understand these tracker formats, the codec buffer size would
> really limit the usefulness of such a thing.
> This patch has been on flyspray for ages. It would be nice to finally
> be able to accept it.
Another question, just to get this clear:
Are you pushing for inclusion of the mikmod *plugin* or the mikmod *codec*?
The last patch on that FS task (1 october 2010) is a codec patch.
What are the pros and cons of a plugin vs. codec in your opinion?
At least for .mod files, I know they have at least the following limitations:
* very limited metadata (basically just the title of the song)
* many (all?) .mod files are looping, so there isn't a good definition of
track length, also a looping .mod has no end after we can skip to the
* we can't seek in a .mod (at least our mod player can't)
IMO, considering these limitations (but I only considered only .mod files)
I think having it as a plugin instead of a codec is no problem.
Received on 2010-11-04