Rockbox mail archiveSubject: Re: FS#6321 - Universal Image Viewer
Re: FS#6321 - Universal Image Viewer
From: Teruaki Kawashima <kamekun_at_r6.dion.ne.jp>
Date: Wed, 10 Nov 2010 00:57:28 +0900
(2010/11/09 1:42), Marcin Bukat wrote:
> 2010/11/8 Teruaki Kawashima<kamekun_at_r6.dion.ne.jp>:
>> I'd like to ask for testers for FS#6321 - Universal Image Viewer
>> The patch unifies jpeg viewer, png viewer, and bmp viewer to one plugin,
>> image viewer so that you can navigate through different image formats.
>> Downside might be that the images without proper extension won't be
>> loaded (e.g. .png for png files.)
> The proper solution would be to look for magic number in file header also.
> jpeg: ff d8 ff e0
> bmp: 42 4d
> png: 89 50 4e 47 0d 0a 1a 0a
Thank you for suggestion and information.
I agree that it would be better to look for magic number.
but I'll leave it for now unless it causes serious problem that judging
Received on 2010-11-09