Rockbox mail archiveSubject: Re: FS#6321 - Universal Image Viewer
Re: FS#6321 - Universal Image Viewer
From: Teruaki Kawashima <kamekun_at_r6.dion.ne.jp>
Date: Wed, 10 Nov 2010 20:31:11 +0900
(2010/11/10 1:16), Alex Parker wrote:
> On 9 November 2010 16:57, Teruaki Kawashima<kamekun_at_r6.dion.ne.jp> wrote:
>> Thank you for suggestion and information.
>> I agree that it would be better to look for magic number.
>> but I'll leave it for now unless it causes serious problem that judging by
> Whether going on file extensions generally works or not, is there a reason
> not to use the magic numbers seeing as everyone seems to have agreed that
> that would be better?
The patch is already large enough to me and I don't feel like to add
another feature which might introduce another issue.
It can be changed to use magic number later if it is desired.
Received on 2010-11-10