|
Rockbox mail archiveSubject: Re: kugel: r28548 - in trunk: android/src/org/rockbox apps/gui/bitmap firmware/drivers firmware/export firmware/export/config firmware/target/hosted/android firmware/target/hosted/sdlRe: kugel: r28548 - in trunk: android/src/org/rockbox apps/gui/bitmap firmware/drivers firmware/export firmware/export/config firmware/target/hosted/android firmware/target/hosted/sdl
From: Maurus Cuelenaere <mcuelenaere_at_gmail.com>
Date: Thu, 11 Nov 2010 13:48:45 +0100 Op 11-11-10 13:43, Björn Stenberg schreef: >> Op 11-11-10 12:18, Teruaki Kawashima schreef: >>>> +/* this are not actually the correct dimensions (480x272 is correct) >>>> + * should be fixed once there's a working LCD driver */ >>>> +#define LCD_WIDTH 480 >>>> +#define LCD_HEIGHT 272 >>>> +#define LCD_DPI 128 > Maurus Cuelenaere wrote: >> See [1], [2] and [3]. > These links all say that 480x272 is correct. The comment says both that 480x272 is correct _and_ that it is incorrect. > > If 480x272 is indeed the correct dimension, the comment should be removed. So it should, this was probably a leftover from Thomas' original diff. I'll remove it unless someone beats me to it. -- Maurus CuelenaereReceived on 2010-11-11 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |