Rockbox mail archiveSubject: Re: kugel: r28548 - in trunk: android/src/org/rockbox apps/gui/bitmap firmware/drivers firmware/export firmware/export/config firmware/target/hosted/android firmware/target/hosted/sdl
Re: kugel: r28548 - in trunk: android/src/org/rockbox apps/gui/bitmap firmware/drivers firmware/export firmware/export/config firmware/target/hosted/android firmware/target/hosted/sdl
From: Teruaki Kawashima <kamekun_at_r6.dion.ne.jp>
Date: Fri, 12 Nov 2010 21:18:28 +0900
(2010/11/12 0:26), Thomas Martitz wrote:
> On 11.11.2010 13:48, Maurus Cuelenaere wrote:
>> Op 11-11-10 13:43, Björn Stenberg schreef:
>>>> Op 11-11-10 12:18, Teruaki Kawashima schreef:
>>>>>> +/* this are not actually the correct dimensions (480x272 is correct)
>>>>>> + * should be fixed once there's a working LCD driver */
>>>>>> +#define LCD_WIDTH 480
>>>>>> +#define LCD_HEIGHT 272
>>>>>> +#define LCD_DPI 128
>>> Maurus Cuelenaere wrote:
>>>> See ,  and .
>>> These links all say that 480x272 is correct. The comment says both
>>> that 480x272 is correct _and_ that it is incorrect.
>>> If 480x272 is indeed the correct dimension, the comment should be
>> So it should, this was probably a leftover from Thomas' original diff.
>> I'll remove it unless someone beats me to it.
> Right, I'm sorry. The comment is now incorrect. A previous version of
> the patch maintained the incorrect dimensions but it was suggested to
> just fix the dimensions while at it.
> Best regards.
i see. thank you all.
Received on 2010-11-12