Rockbox mail archive
Subject: Re: jdgordon: r28714 - trunk/apps/gui/skin_engineRe: jdgordon: r28714 - trunk/apps/gui/skin_engine
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Magnus Holmgren <magnushol_at_gmail.com>
Date: Wed, 1 Dec 2010 22:10:13 +0100
On Tue, Nov 30, 2010 at 23:15, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
> strncmp was also used because otherwsie it was actually broken. I'm
> pretty sure the parser does not strip trailing spaces, so %if(foo, = ,
> bar) would get rejected. The mentioned speedup was more hopefully from
> it not checking every case once one was found.
I managed to miss the else's there. Sorry. :)
Date: Wed, 1 Dec 2010 22:10:13 +0100
On Tue, Nov 30, 2010 at 23:15, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
> strncmp was also used because otherwsie it was actually broken. I'm
> pretty sure the parser does not strip trailing spaces, so %if(foo, = ,
> bar) would get rejected. The mentioned speedup was more hopefully from
> it not checking every case once one was found.
I managed to miss the else's there. Sorry. :)
-- MagnusReceived on 2010-12-01
Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy