From: Alex Parker <parker.alex.e_at_gmail.com>
Date: Sun, 13 Feb 2011 11:01:29 +0100

On 13/02/11 10:39, Magnus Holmgren wrote:
> Hi,
>
> I must say I'd prefer if the embedded album art got a lower priority. If
> it can't be decoded (or you'd just prefer another one), there's no easy
> way to override the embedded one. That's annoying, especially when
> dealing with things like podcasts. It'd be nice to just drop a file
> (once) on the DAP to override the embedded one. Making "external" album
> art higher priority would fix that, but I can see a point in letting
> embedded art override "album level" art. Any opinions on that?

My feeling is that embedded should be higher than an album level image
(such as folder.jpg) - that way tracks that have specific art use it,
otherwise an album/folder image wins. However I can see the argument
for having track level external files come first, so we get:

track specific external file
embedded art
external album level art

I think this is the order I'd go for.

> Regardless of the priority question, it looks easy to make Rockbox
> ignore album art if it can't be decoded, with fairly small changes to
> playback.c. I'll put a patch for that on Flyspray, once I've tested it a
> bit.

Yes, if embedded art fails to decode, it should definitely carry on down
the chain. We are due to feature freeze later on today, but I'd
consider this a bug fix anyway.

Alex
Received on 2011-02-13