Rockbox mail archiveSubject: Re: FS#11615 - dynamic screen size.. time to commit
Re: FS#11615 - dynamic screen size.. time to commit
From: Thomas Martitz <thomas.martitz_at_student.htw-berlin.de>
Date: Sun, 13 Mar 2011 12:32:31 +0100
On 13.03.2011 11:19, Jonathan Gordon wrote:
> Hi all,
> I want to finally commit http://www.rockbox.org/tracker/task/11615
> which allows runtime LCD size detection for the sdl app. no
> significant changes to targets without HAVE_DYNAMIC_LCD_SIZE defined
> (a few checks go from preprocessor to c if's but shouldn't be a big
> So, I'll wait untill midweek for further comments before commiting.
> Enabling this does take credits and pictureflow and some other plugins
> out of the build, and they may not be easy to put back in BUT untill
> RaaA builds are done automatically (i.e not relying on individuals to
> do the builds) I don't see this as a big issue. And even then, this is
> only being enabled for sdlapp for now.
> This does leave a few questions open but I think unless this starts
> getting commited nothing will happen..
> * Do we load screen sized bmp/jpg logos from disk instead of compiling
> in? It should only be the boot logo affected.
> * plugins (We *could* build each .rock for multiple hardcoded sizes
> which will work with the dynamic screen size build. android (as an
> example) could download the .zip for the devices screen size which
> would also include the cabbie theme)
> * a few settings have hard coded (but mostly arbitrary) values which
> are calculated from the screen size, how do we deal with that?
> Like I said, I don't tihnk any of that is a reason to hold this off
> any longer, doing so would just mean nothing happens for another 3
Does it also fix actual problems, or does it only introcuce some
(disabled plugins, wrongly sized rockbox logo, arbitrary values for
Received on 2011-03-13