From: Magnus Holmgren <magnushol_at_gmail.com>
Date: Mon, 25 Apr 2011 22:18:53 +0200

(Re-sending it to a better address. :)

-------- Original Message --------
Subject: Re: Buschel: r29778 - in trunk/apps/codecs: . libfaad
Date: Mon, 25 Apr 2011 22:16:15 +0200
From: Magnus Holmgren <magnushol_at_gmail.com>
To: rockbox-cvs_at_cool.haxx.se

On 2011-04-24 22:19, mailer_at_svn.rockbox.org wrote:

> New Revision: 29778
>
> Log Message:
> Rework of libfaad in several areas.

I was building r29783 with GCC 4.6.0, and I got a bunch of warnings for the
hInfo->channel_position assignments in NeAACDecDecode (in decoder.c, starting at
line 605, "warning: array subscript is above array bounds [-Warray-bounds]").
Maybe that code should be guarded by a MAX_CHANNELS #if? Is there any code
elsewhere preventing that code from being run?

-- 
   Magnus

Received on 2011-04-25