Rockbox mail archiveSubject: Re: kugel: r30039 - trunk/firmware/common
Re: kugel: r30039 - trunk/firmware/common
From: Magnus Holmgren <magnushol_at_gmail.com>
Date: Mon, 20 Jun 2011 23:30:24 +0200
On 2011-06-20 22:12, mailer_at_svn.rockbox.org wrote:
> Optimize new dircache_copy_path so that the helper (strlcat) doesn't need to
> walk through the entire string repeatedly.
Is it really a performance problem? Avoiding this kind of pointer/buffer size
juggling is one of the reasons for using strlcpy/strlcat.
> Also fix a off-by-one.
Not really, as strlcpy/strlcat takes the full size of the buffer as argument.
Unless it is needed because of the offset juggling? :)
-- MagnusReceived on 2011-06-20