Rockbox mail archiveSubject: Re: Git/gerrit migration status and next steps
Re: Git/gerrit migration status and next steps
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Wed, 7 Sep 2011 17:36:52 +1000
On Sep 7, 2011 5:32 PM, "Marcin Bukat" <marcin.bukat_at_gmail.com> wrote:
> 2011/9/7 Jonathan Gordon <jdgordy_at_gmail.com>:
> > On 7 September 2011 00:40, Torne Wuff <torne+rockboxdev_at_wolfpuppy.org.uk>
> >> 4) We write up policies and documentation on how to use git via
> >> gerrit, though only two parts are crucial at this point: how to clone
> >> the repositories, and how committers can commit directly to master.
> > Do we really want to allow commits directly? so little of our code
> > ever gets reviewed so I would quite happily force everyone to go
> > through gerrit and require someone else to OK it. It isnt hard to get
> > someone else in IRC to have a quick look and push the button.
> For general rb work that's ok but for new ports this may be problematic.
Why? Just come in irc and ask someone to press the button. They don't need
to do a full blown revue
Received on 2011-09-07