dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: Git/gerrit migration status and next steps

Re: Git/gerrit migration status and next steps

From: Frank Gevaerts <>
Date: Wed, 7 Sep 2011 10:22:12 +0200

On Wed, Sep 07, 2011 at 05:59:31PM +1000, Jonathan Gordon wrote:
> This isn't about people doing the wrong thing. This is about trying to get
> code quality. And yes it will be a minor pain sometimes, but a small fix has
> just as much fuck-up-ability as a big one and is *easier* to sanity check
> then the required debugging later.
> This is something gerrit makes easy and we should absolutly do it. Remember
> that you push directly to gerrit, this doesn't require you to open your
> browser.

That isn't the problem. The problem is that we would like to have more
than three commits actually getting in every month.

Unless someone personally promises to review every single patch within 24
hours, I'm against this.


"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
Received on 2011-09-07

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy