dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: Git/gerrit migration status and next steps

Re: Git/gerrit migration status and next steps

From: Dominik Riebeling <>
Date: Wed, 7 Sep 2011 21:31:29 +0200

On Wed, Sep 7, 2011 at 1:41 PM, Jonathan Gordon <> wrote:
> My intuition says that commiters will use it exactly like flyspray,
> i.e very rarely. I am looking forward to being able to push new
> contirbuters patches more quickly though.

I recently put up a couple of patches on Flyspray instead of
committing directly. After a while I was asked why I'm not committing
things directly. Given the fact that there were almost no (none?)
comments on those FS tasks this question did make sense, but as people
didn't comment on FS tasks I don't expect more activity when a
committer pushes a patch for review through gerrit.

I'm with Torne on requiring reviews for release branches, but for
trunk I don't see that working. And I also agree that it makes sense
to make one change at a time.

 - Dominik
Received on 2011-09-07

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy