|
Rockbox mail archiveSubject: Re: jdgordon: r30599 - in trunk/apps: . gui/skin_engineRe: jdgordon: r30599 - in trunk/apps: . gui/skin_engine
From: Thomas Martitz <kugel_at_rockbox.org>
Date: Wed, 28 Sep 2011 09:00:50 +0200 Am So, 25.09.2011, 16:54 schrieb Thomas Martitz: > Hello, > > I want to discuss that commit as I disagree with it in some ways, > perhaps even see it reverted. > > Clearly it introduced a user configurable skin buffer. That is something > we discussed many times before with no clear outcome. In fact, in my > memory there was a general opposition. I feel it silently introduced a > NoDo, although the wiki page doesn't list it. > So I'm bitter that this is introduced via a drive-by commit with no > mention about it at all. This is not the policy I want to see for > controversial changes. Does anyone want to comment on this one? User configurable buffer sizes were questionable/controversial in the past (if not to avoid generally). Which is more easy than ever with buflib. I'm surprised nobody has an opinion on this now. TBH, I would like to revert this commit. Best regards. Received on 2011-09-28 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |