Rockbox mail archiveSubject: Re: jdgordon: r30599 - in trunk/apps: . gui/skin_engine
Re: jdgordon: r30599 - in trunk/apps: . gui/skin_engine
From: Thomas Martitz <kugel_at_rockbox.org>
Date: Wed, 05 Oct 2011 14:47:48 +0200
Am 05.10.2011 09:44, schrieb Jonathan Gordon:
> Go ahead, just remember you're then responsible for breaking users
> ability to load their otherwise working themes. Frankly the 2 users
> whom I've personally helped trumps your (very likely personal) reasons
> against the change.
If there are themes that worked before the buflib changes, then it's a
regression in the buflib changes.
> Heck, read the thread, you're the only one who has said anything about
> the actual feature, everyone else just doesnt like the implementation
> (myself included to be completely honest).
A bad implementation is enough reason to revert in my book. But I'm also
unhappy nobody commented on the feature itself (pro or against).
> But unless you're going to
> do something about the apparent ram waste, or reimplement this is a
> nicer way, then you reverting is just a dick thing to do.
"If you don't like this way, go implement it your way or leave me alone"
isn't how things work in our project.
Received on 2011-10-05