From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sat, 8 Oct 2011 21:47:38 +1100

On 8 October 2011 05:18, Thomas Martitz <kugel_at_rockbox.org> wrote:
> Hello folks,
>
> I finally uploaded the patch that's lived long in my git repo (although in
> very hacked together fashion). I'm making this post here too since I want to
> get it in quickly. So please have a play with it and speak up if you have
> objections.
>
>> This patch adds line padding to lists on touchscreens, in order to make
>> lists reasonable useful without huge fonts.
>>
>> It's configurable:
>> * Automatic (default, line height calculated using a lcd dpi aware
>> function)
>> * Off (status quo, line height = font height)
>> * X pixels (from 2 to 50 in even steps)
>>
>> The automatic setting should/aims to Just Work Out Of The Box on all
>> targets
>>
>> IMO this patch is needed to make Rockbox on touchscreen/RaaA remotely
>> usable.
>>
>> Please comment or make suggestions!
>
>
> Best regards.
>

This will probably be ignored but meh.
This is the wrong patch for 2 reasons:
1) this can already be done in the themes
2) the only reason this is wanted at all is because Raaa doesnt use
native lists. The effort shold be put into making native lists work
(which is trivial once someone figures out how to draw the List in the
Canvas rockbox uses. androids list api and rockbox's is pretty
similiar (similar enough that a mostly thin wrapper is all that is
needed).
Received on 2011-10-08