Rockbox mail archiveSubject: Re: FS#12321 - Touchscreen: List line padding, to more easily select lines
Re: FS#12321 - Touchscreen: List line padding, to more easily select lines
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sun, 9 Oct 2011 18:38:53 +1100
On 9 October 2011 18:38, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
> 30min of fiddling around, attached is the screenshot from the e200 sim
> and the patch to do it, notice there is no code needed anywhere
> outside of the skin engine (infact its only done there because that
> pulls in the generated .sbs if none is specified). No actual code
> needs changing.
> Notes about the screenshot:
> * I'm not sure why the images arent being displayed, that might be a
> skin engine bug, more likely PEBCAK.
> * Gradient isnt completly setup in that example
> Now, I haven't seen screenshots from kugels patch, but if it colours
> the whole line instead of just the text, then that can be fixed with
> minor changes to the skin engine (wanted to do that anyway). Though it
> requires the lcd driver get a draw more which is "use the current
> pixels for the transparent pixels instead of the backdrop image) which
> IIUC amiconn has mentioned he wants to add for a while now. If kugels
> patch is the same as that screenshot then the above is still something
> which should be done :) (hardly a reason to not go by this
> implementation anyway).
> With a bit more fiddling this could be *easily* extended to *any*
> skinned list theme by just fiddling with the Lb() tag.
DAMMIT! pressed send before ataching the patch