|
Rockbox mail archiveSubject: Re: Trimming the lcd apiRe: Trimming the lcd api
From: Amaury Pouly <amaury.pouly_at_gmail.com>
Date: Wed, 12 Oct 2011 12:28:57 +0200 > lcd_puts > ... > lcd_putsxyf > > Some statistics can be useful, so here is a updaded list with the number of callers. METHOD: grep -R "function(" ./apps/ ./firmware lcd_puts: 302 lcd_puts_offset: 4 lcd_puts_scroll: 106 lcd_puts_scroll_offset: 3 lcd_puts_scroll_style: 3 lcd_puts_scroll_style_offset: 1 lcd_puts_scroll_style_xyoffset: 1 lcd_puts_style: 4 lcd_puts_style_offset: 1 lcd_puts_style_xyoffset: 1 lcd_putsf: 483 lcd_putsxy: 358 lcd_putsxy_style_offset: 1 lcd_putsxyf: 81 So yes I agree that we should trim the api, but we should also keep the most called function to avoid increasing binsize. Keeping lcd_puts and lcd_putsf seems like a good deal. Best regards Received on 2011-10-12 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |