Rockbox mail archiveSubject: Re: fredwbauer: r30826 - in trunk: apps apps/gui firmware firmware/export
Re: fredwbauer: r30826 - in trunk: apps apps/gui firmware firmware/export
From: Björn Stenberg <bjorn_at_haxx.se>
Date: Mon, 24 Oct 2011 09:55:15 +0200
Jonathan Gordon wrote:
> Can this please be reverted? firmware/fonts.c should now know or care
> about the ui font at all, and post buflib fonts it doesnt.
> screen_access.c added a helper to set the font
> (screens[screen].set_font() ) which should be being used by the
> keyboard and lrcviewer.
I agree. The screen api solves this (or should solve it) without having to expand the firmware font.h api.
> Ideally a font_get_height() function be added which (to the screen
> api) to get the correct font height seen as that is what most calls to
> font_get() actually care about.
We even have it already, screen.getcharheight() returns the current font height.
-- BjörnReceived on 2011-10-24