Rockbox mail archiveSubject: Re: fredwbauer: r30826 - in trunk: apps apps/gui firmware firmware/export
Re: fredwbauer: r30826 - in trunk: apps apps/gui firmware firmware/export
From: Thomas Martitz <kugel_at_rockbox.org>
Date: Tue, 25 Oct 2011 08:35:07 +0200
Am 25.10.2011 07:50, schrieb Jonathan Gordon:
> Attached is 90% of the work to do this somewhat more nicely.
> The remaining work is to check each plugin and make sure they don't
> use lcd_setfont() directly (which a quick look shows alot do :( ) the
> quick fix for that is just put a wrapper in the plugin api for it like
> what has been added for the screen_access api.
Plugins can use the screen_access api. Ideally those should be using a
custom viewport if they want a custom font, right?
Might be worthwhile also to check if font_get(vp->font)->height calls
can be replaced with screen->getcharheight(). I admit I forgot about
that one before Björn mentioned it and used the former too.
One question about the patch though: Why separate setfont() and
setuifont()? I imagine one could be sufficient, but perhaps I'm missing
Received on 2011-10-25