Rockbox mail archiveSubject: Re: RDS support in Rockbox
Re: RDS support in Rockbox
From: Amaury Pouly <amaury.pouly_at_gmail.com>
Date: Sat, 5 Nov 2011 01:29:07 +0100
> I doubt all that is necessary especially with a tuner GPIO interrupt
> available in at least some cases and possibly the introduction of an async
> I2C driver (not too hard really). I'd suggest not imposing a particular
> interface on all hardware but have the hardware implement those details as
> a middle layer.
> I think the proposed implementation is specific to this hardware.
> When the FM frequency is changed, the RDS data is invalidated with
>> - void rds_reset(void)
> Why not just reread it? The UI can clear its fields. The tuner can
> indicate a frequency change internally and clear its own data.
> The point is that when you change the frequency you need to tell the
generic RDS parser that its data is invalid because it might have some
partials packet pending and need to work them I guess.
Perhaps I'm misunderstanding the initial proposal and/or your objections
but the way I see it this like this:
Driver ==> Generic RDS <== UI Code
The Driver pushes raw packets to the parser and the UI Code ask the generic
parser what is data available.
Received on 2011-11-05