|
Rockbox mail archiveSubject: Re: RDS support in RockboxRe: RDS support in Rockbox
From: Amaury Pouly <amaury.pouly_at_gmail.com>
Date: Sat, 5 Nov 2011 12:03:26 +0100 > Using another thread is probably (maybe) overkill on AMSv2 and i.MX31 and > RDS isn't exactly a data flood so doing it without a thread from an I2C > interrupt callback is probably economical. I'm not sure if any AMSv2 > players actually have an int line from the tuner chip though. The latter as > I recall does have it (it's been awhile). > > > I think the proposed implementation is specific to this hardware. >>> >> ... I think you misunderstood my point, you can implement it differently with another hardware without any problem. The proposed rds_ interface doen't imply a particular way of doing things, is it ? RDS data can be cleared from the tuner driver with better timing control > (like when to mask it and unmask it for tuning to avoid races), probably > with less error proneness and more importantly proper operation should not > depend on being inside a particular UI-- it's akin to key playback features > only working inside the WPS. Why continue down that path? It's finally > showing its obvious limitations as far as control from other screens. Just > add another event callback definition that the UI can register for. > > I think that what bertrik proposed is to call it from the driver and not from the UI. Calling it from the UI would make no sense. Received on 2011-11-05 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |