|
Rockbox mail archiveSubject: Re: Working towards skin engine 2.0 (includes RFC on code!)Re: Working towards skin engine 2.0 (includes RFC on code!)
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Wed, 9 Nov 2011 09:00:50 +1100 On 9 November 2011 01:06, Magnus Holmgren <magnushol_at_gmail.com> wrote: > On Tue, Nov 8, 2011 at 14:17, Jonathan Gordon <jdgordy_at_gmail.com> wrote: > >> Well, >> I honestly didnt think it would be this simple! Attached is the >> changes removing all dynamic pointers from the skin engine! > > One question: Since SKINOFFSETTOPTR and PTRTOSKINOFFSET both include a > conditional and are used a lot, what happens with binsize? :) > > -- > Magnus > It really doesnt matter, they could add 1KB and we'd still be ~17KB better off on most targets. The skin buffer currently over allocates for cabbie by nearly 20KN on some targets. Received on 2011-11-08 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |