Rockbox mail archiveSubject: Re: Working towards skin engine 2.0 (includes RFC on code!)
Re: Working towards skin engine 2.0 (includes RFC on code!)
From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sun, 13 Nov 2011 23:51:10 +1100
This one actually puts the skin buffers onto buflib. I'm pretty
confident I got all the bugs so aiming to commit this midweek unless
anyone finds any issues :)
After this is in svn I'll work on making the skin engine more flexible
again (skins dont all need to be loaded/unloaded together anymore),
and go back to allowing skins to be loaded from outside the
On 9 November 2011 20:38, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
> Attached fixed Michael's bugs.
> I cant do another round of builds untill tommorow which is abit
> annoying, but I can do individual ones on request
> On 9 November 2011 12:16, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
>> Test builds are available at http://jdgordon.info/rockbox/skintestbuilds/output/
>> On 9 November 2011 09:01, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
>>> On 9 November 2011 01:12, Michael Chicoine <mc2739_at_gmail.com> wrote:
>>>> On Tue, Nov 8, 2011 at 7:17 AM, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
>>>>> Testing is pretty much: Apply and run your themes. If it works there
>>>>> should be no difference at all.
>>>> A quick test on e200v1 with cabbiev2 (r30933) shows the following issues:
>>>> 1. FM Radio screen is blank (except backdrop and statusbar). After
>>>> settings clear, it does not even display the "No settings found.
>>>> Autoscan?" message.
>>>> 2. WPS displays incorrect icons: playmode always shows stop icon, hold
>>>> icon shows locked when locked or unlocked, repeat mode shows
>>>> repeat-all in all repeat modes.
>>> Crap! I've been testing with the video sim, it should all work
>>> everywhere :/ thanks for testing