Rockbox mail archiveSubject: Re: Working towards skin engine 2.0 (includes RFC on code!)
Re: Working towards skin engine 2.0 (includes RFC on code!)
From: Frank Gevaerts <frank_at_gevaerts.be>
Date: Sun, 13 Nov 2011 15:32:25 +0100
On Mon, Nov 14, 2011 at 01:13:47AM +1100, Jonathan Gordon wrote:
> On 14 November 2011 01:09, Frank Gevaerts <frank_at_gevaerts.be> wrote:
> > If someone could come up with a way to make OFFSETTYPE() actually *do*
> > something (a clever way to do type checking, maybe), I'd agree. The way
> > it stands now it's just as easy to overlook as a comment when changing
> > things, and *nothing* will complain (the thing given there doesn't even
> > have to be a valid type...).
> At a minimum it is needed so the same maasive rework isnt needed in
> the theme editor.
Ok, so OFFSETTYPE() allows us to compile the code with plain traditional
pointers if and where we want to. This could also allow more thorough
checking of the types in the code.
Those seem worthwhile to me, so I'm fine with this part of the patch
(I haven't looked deeply at the rest)
-- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. KernighanReceived on 2011-11-13