Rockbox mail archiveSubject: Re: Performance regression
Re: Performance regression
From: Thomas Jarosch <tomj_at_simonv.com>
Date: Thu, 1 Dec 2011 22:18:42 +0100
Am Donnerstag, 1. Dezember 2011, 19:02:28 schrieb Michael Sevakis:
> One more thing. You mentioned maemo and really, I did not work on that so
> much. I just took my best guess at what to do with it in r30097 and noone
> was conveniently around to check it. I also noticed the lack of
> pcm_play_lock/unlock implementations.
Actually I did a test build back then (still floating around on my phone)
and everything was working fine. I didn't notice the performance drop.
Maemo doesn't need pcm_play_lock() as the locking is done
on the gstreamer object level.
Anyhow, it turned out to be the software mixing and you already
gave the solution: After an increase of the software mixer buffer size
from 256 to 2048, CPU usage is back to normal.
Is that a size we still can live with?
Also have a look at FS #12421, that squeezes out
a bit more performance on RaaA.
Thanks for you effort not to break maemo when you commited r30097.
Received on 2011-12-01