Rockbox mail archiveSubject: The V2 and FM Recorder charging screen issue (FS#7631)
The V2 and FM Recorder charging screen issue (FS#7631)
From: Boris Gjenero <boris.gjenero_at_gmail.com>
Date: Thu, 22 Dec 2011 16:30:32 -0500
I would like to finally fix the Archos V2 and FM Recorder charging
screen issue (FS#7631). One problem remains: ATA power is required to
measure battery voltage. If ATA power is off, measured battery voltage
is close to 0V, and the power management thread initiates a low battery
shutdown. ATA power needs to stay turned off during the charging screen
to ensure proper operation if the battery is very discharged.
My solution is simple: on these targets, delay powermgmt_init() until
after storage_init(). I use defined(NEED_ATA_POWER_BATT_MEASURE) &&
(CONFIG_CHARGING <= CHARGING_MONITOR) to delay powermgmt_init(). Only
defined(NEED_ATA_POWER_BATT_MEASURE) is required, but adding the second
part seems better because power management code is needed for charging
This does not help when defined(NEED_ATA_POWER_BATT_MEASURE) &&
defined(HAVE_ATA_POWER_OFF), but no targets are like that. It also
doesn't fully address defined(NEED_ATA_POWER_BATT_MEASURE) &&
(CONFIG_CHARGING == CHARGING_TARGET), but again, no targets are like
that. I don't think adding code for either is desirable.
I also change the charging screen for the Archos V2 and FM recorder to
display input current instead of voltage. That way, the user gets some
feedback regarding what's going on with charging.
The patch is at http://www.rockbox.org/tracker/task/7631?getfile=24558
I would like to commit it soon. I just want to see if there are
objections and if anyone else has a better idea.
Received on 2011-12-22