Rockbox mail archiveSubject: Re: Should we enable -Wmissing-declarations?
Re: Should we enable -Wmissing-declarations?
From: Bertrik Sikken <bertrik_at_sikken.nl>
Date: Thu, 29 Dec 2011 12:01:55 +0100
On 21-12-2011 7:53, Boris Gjenero wrote:
> With -Wmissing-declarations, gcc can warn about non-static global
> functions and data without a previous declaration. What do others think
> about the idea of enabling the warning for the core, after some cleanup?
I am generally in favour of this.
For the core, we could go for strict compliance, with perhaps only an
exception for C code referenced from assembler code. We're already
IMO, I think we can also do this for codecs. For plugins it doesn't
matter so much and much of the code is "foreign" anyway.
Received on 2011-12-29