|
Rockbox mail archiveSubject: Re: Should we enable -Wmissing-declarations?Re: Should we enable -Wmissing-declarations?
From: Thomas Martitz <kugel_at_rockbox.org>
Date: Thu, 29 Dec 2011 12:11:40 +0100 Am 29.12.2011 12:01, schrieb Bertrik Sikken: > On 21-12-2011 7:53, Boris Gjenero wrote: >> With -Wmissing-declarations, gcc can warn about non-static global >> functions and data without a previous declaration. What do others think >> about the idea of enabling the warning for the core, after some cleanup? > I am generally in favour of this. I agree. > For the core, we could go for strict compliance, with perhaps only an > exception for C code referenced from assembler code. We're already > nearly there. I agree. > IMO, I think we can also do this for codecs. For plugins it doesn't > matter so much and much of the code is "foreign" anyway. Most of the codecs code is foreign too, perhaps even more so that plugins. Best regards. Received on 2011-12-29 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |