|
Rockbox mail archiveSubject: Re: usb.c warningRe: usb.c warning
From: Michael Sevakis <jethead71_at_comcast.net>
Date: Wed, 4 Jan 2012 11:08:14 -0500 Yes. It's just like "status = (status == USB_INSERTED) ? status : USB_EXTRACTED;" > Hi, > > Noticed a warning for this code in firmware/usb.c, line 557 (as of > r31578): > > status = (status == USB_INSERTED) ? : USB_EXTRACTED; > > According to the gcc manual (section 5.7), the expression "x ? : y" (a gcc > extension) has the value x if x is nonzero, otherwise z. So, status is set > to "true" or "USB_EXTRACTED". In this case, true happens to have the same > value as USB_INSERTED... Is that what was intended here? > > -- > Magnus Received on 2012-01-04 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |