From: Nick Peskett <rockbox_at_peskett.co.uk>
Date: Wed, 28 Mar 2012 12:14:03 +0100

On 27/03/2012 23:33, Jonathan Gordon wrote:
> I dont' see discussion in either of those links about stripping the
> options down, and anyway, they can probably be ignored anyway. Would
> you like to split it back to how it was?

I think the main objection with the way I'd split it, if a user was
always choosing different sleep timer durations, it would be two menu
options instead of one.

I might have imagined it though, I just bookmarked the logs at the time
and haven't gone back through them since.

I've submitted a version of the original split for review.

http://gerrit.rockbox.org/201

Cheers,

Nick
Received on 2012-03-28