From: Bertrik Sikken <bertrik_at_sikken.nl>
Date: Sun, 08 Jul 2012 01:08:46 +0200

Hi Mike,

On 6-7-2012 12:30, Mike Giacomelli wrote:
> Hi Everyone.
>
> I've implemented a new logging system for rockbox to eventually
> replace DEBUGF and LOGF. The new system is very similar to the old,
> but with 2 significant improvements:
>
> 1) It uses the register_storage_idle_func to write log files to disk
> during spin up. This is similar to how config files and battery bench
> logs are handled. Thus, there is no loss of battery life from
> logging.
>
> 2) There is a priority system for logging, such that the amount of
> data logged is configurable. In addition, each entry to the log is
> prepended with the function name that called it (and hopefully the
> source file name once we have the makefile issues worked out). By
> default, the preprocessor eliminates all non-error messages.
>
> With these improvements, I plan to change the logging system to record
> critical errors by default on both dev and release builds. This will
> greatly simplify trouble shooting, particularly for users who often
> have no way to figure out why Rockbox refuses to read a file, crashes
> when building a database, etc. It will hopefully aid us in tracking
> down rare crashes, particularly in places like codecs, bufflib, and
> theme parsing by allowing users provide debug information directly.
>
> I would appreciate it if people would take a look and provide feedback:

I haven't checked out the patch yet, but I just want to say I think this
is a great idea and I appreciate you taking the initiative for this.

With kind regards,
Bertrik
Received on 2012-07-08