From: Magnus Holmgren <magnushol_at_gmail.com>
Date: Fri, 27 Jul 2012 18:39:17 +0200

On 2012-07-27 18:00, Rafaël Carré wrote:

>> A call to codec_set_replaygain() when starting a new track should be enough. It
>> looks like the existing tag parsing code is used; if so Replaygain tags are
>> already handled.
>
> I think the tags are not read at all from the file:
>
> http://git.videolan.org/?p=vlc.git;a=blob;f=modules/codec/vorbis.c;h=f833f1c10e4e7e1f8b87ac10bade4f23f92db9e0;hb=HEAD#l558
>
> git grep \"REPLAYGAIN shows no result

The existing Ogg metadata reader in Rockbox is used, which already handles the
replaygain tags (metadata.c points to get_ogg_metadata, and other Ogg-related
metadata code is updated to check for Opus specific tags). So I'd expect that
call is all that is missing.

-- 
   Magnus

Received on 2012-07-27