|
Rockbox mail archiveSubject: Re: 540e5d1: Forget about fixedpoint.c in any HWCODEC bin.Re: 540e5d1: Forget about fixedpoint.c in any HWCODEC bin.
From: Thomas Martitz <kugel_at_rockbox.org>
Date: Tue, 16 Apr 2013 07:46:38 +0200 Am 16.04.2013 00:56, schrieb Michael Sevakis: >> Calling apps/ code from firmware? That's bad! >> >> Why not move fixedpoint to firmware (or into the top level lib folder)? >> >> Best regards > > It was causing weird issues with codeclib, where if built into > libfirmware and not referenced internally to libfirmware, the > functions would be dropped and codeclib would fail to link. I wasn't > yet in the mood to make it work properly, so I just moved the header > to firmware/export. There would still be an issue since only sw volume > control uses it within /firmware itself. Hmm, how can that happen? Creating a libX.a is just packing *.o into an archive, regardless of internal references. It doesn't even involve the linker. If codeclib (from /lib/rbcodec), which we ideally want to work outside Rockbox, uses this then fixed point should also be somewhere in /lib IMO. Best regards. Received on 2013-04-16 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |